[PATCH] D68903: [LNT] NFC: Fix order of globals and locals on exec

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 12 01:50:54 PDT 2019


thopre accepted this revision.
thopre added a comment.
This revision is now accepted and ready to land.

LGTM but would suggest this altered description:

Per https://docs.python.org/3/library/functions.html#exec, globals parameter comes before locals. Since globals and locals refer to the same object for the call in question, we can remove locals, which will make globals used for both the global and the local variables, thus keeping the same behavior.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68903/new/

https://reviews.llvm.org/D68903





More information about the llvm-commits mailing list