[PATCH] D68906: [llvm-size] Tidy up error messages

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-size/llvm-size.cpp:110
 
-static bool error(Twine Message) {
+static bool error(StringRef File, Twine Message) {
   HadError = true;
----------------
I'd prefer `error(Twine Message, StringRef File)`. Note the error below places the error (for error message) at the first argument position.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68906/new/

https://reviews.llvm.org/D68906