[llvm] r374623 - [asan] Return true from instrumentModule

[Vitaly Buka via llvm-commits]

Author: vitalybuka
Date: Fri Oct 11 18:50:36 2019
New Revision: 374623

URL: http://llvm.org/viewvc/llvm-project?rev=374623&view=rev
Log:
[asan] Return true from instrumentModule

createSanitizerCtorAndInitFunctions always change the module.

Modified:
    llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp

Modified: llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp?rev=374623&r1=374622&r2=374623&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (original)
+++ llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp Fri Oct 11 18:50:36 2019
@@ -2439,11 +2439,10 @@ bool ModuleAddressSanitizer::instrumentM
       /*InitArgs=*/{}, VersionCheckName);
 
   bool CtorComdat = true;
-  bool Changed = false;
   // TODO(glider): temporarily disabled globals instrumentation for KASan.
   if (ClGlobals) {
     IRBuilder<> IRB(AsanCtorFunction->getEntryBlock().getTerminator());
-    Changed |= InstrumentGlobals(IRB, M, &CtorComdat);
+    InstrumentGlobals(IRB, M, &CtorComdat);
   }
 
   const uint64_t Priority = GetCtorAndDtorPriority(TargetTriple);
@@ -2464,7 +2463,7 @@ bool ModuleAddressSanitizer::instrumentM
       appendToGlobalDtors(M, AsanDtorFunction, Priority);
   }
 
-  return Changed;
+  return true;
 }
 
 void AddressSanitizer::initializeCallbacks(Module &M) {