[PATCH] D68892: [NVPTX] Restructure shfl instrinsics and add variants that return a predicate.

[Tim Shen via Phabricator via llvm-commits]

timshen accepted this revision.
timshen added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/IR/IntrinsicsNVVM.td:280
+class SHFL_INFO<bit sync, string mode, string type, bit return_pred> {
+  string Suffix = !if(sync, "sync_","")
+                  # mode # "_"
----------------
nit: format `if(sync, "sync_","")` to `if(sync, "sync_", "")`


================
Comment at: llvm/include/llvm/IR/IntrinsicsNVVM.td:293
+    !eq(type,"f32"): llvm_float_ty);
+  list<LLVMType> RetTy = !listconcat(
+    [OpType], !if(return_pred, [llvm_i1_ty], []));
----------------
Seems cleaner to just have `= !if(return_pred, [OpType, llvm_i1_ty], [OpType])`.


================
Comment at: llvm/include/llvm/IR/IntrinsicsNVVM.td:295
+    [OpType], !if(return_pred, [llvm_i1_ty], []));
+  list<LLVMType> ArgsTy = !listconcat(
+    !if(sync, [llvm_i32_ty], []),
----------------
ditto.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68892/new/

https://reviews.llvm.org/D68892