[PATCH] D68889: [WebAssembly] Allow multivalue types in block signature operands

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 11 15:29:08 PDT 2019


tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: llvm/tools/llvm-mc/llvm-mc.cpp:520
   if (disassemble)
-    Res = Disassembler::disassemble(*TheTarget, TripleName, *STI, *Str,
-                                    *Buffer, SrcMgr, Out->os());
----------------
sbc100 wrote:
> This change to remove the context creation seems seperate.  If so can you split it out?  That was this change can stay wasm specific.
It's not separate, unfortunately. In order to create a wasm symbol from the disassembler we need a bunch of target information that this target contains that the old one did not have.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68889/new/

https://reviews.llvm.org/D68889





More information about the llvm-commits mailing list