[PATCH] D67768: [DebugInfo] Add interface for pre-calculating the size of emitted DWARF

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

lgtm with inline comments addressed



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h:337
+    SmallString<32> Bytes;
+    SmallVector<std::string, 8> Comments;
+    BufferByteStreamer BS;
----------------
A SmallVector<std::string> doesn't seem to make that much sense, since strings are always heap-allocated. Either this should be a vector<string> or a SmallVector<SmallString>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67768/new/

https://reviews.llvm.org/D67768