[llvm] r374595 - [GISel][UnitTest] Fix a bunch of tests that were not doing anything

[Quentin Colombet via llvm-commits]

Author: qcolombet
Date: Fri Oct 11 13:58:26 2019
New Revision: 374595

URL: http://llvm.org/viewvc/llvm-project?rev=374595&view=rev
Log:
[GISel][UnitTest] Fix a bunch of tests that were not doing anything

After r368065, all the tests using GISelMITest must call setUp() before
doing anything, otherwise the TargetMachine is not going to be set up.
A few tests added after that commit were not doing that and ended up
testing effectively nothing.

Fix the setup of all the tests and fix the failing tests.

Modified:
    llvm/trunk/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
    llvm/trunk/unittests/CodeGen/GlobalISel/MachineIRBuilderTest.cpp

Modified: llvm/trunk/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp?rev=374595&r1=374594&r2=374595&view=diff
==============================================================================
--- llvm/trunk/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp (original)
+++ llvm/trunk/unittests/CodeGen/GlobalISel/KnownBitsTest.cpp Fri Oct 11 13:58:26 2019
@@ -120,17 +120,16 @@ TEST_F(GISelMITest, TestKnownBits) {
 }
 
 TEST_F(GISelMITest, TestSignBitIsZero) {
+  setUp();
   if (!TM)
     return;
 
   const LLT S32 = LLT::scalar(32);
-  auto SignBit = B.buildConstant(S32, 0x8000000);
+  auto SignBit = B.buildConstant(S32, 0x80000000);
   auto Zero = B.buildConstant(S32, 0);
 
   GISelKnownBits KnownBits(*MF);
 
   EXPECT_TRUE(KnownBits.signBitIsZero(Zero.getReg(0)));
-  EXPECT_FALSE(KnownBits.signBitIsZero(Zero.getReg(0)));
   EXPECT_FALSE(KnownBits.signBitIsZero(SignBit.getReg(0)));
-  EXPECT_TRUE(KnownBits.signBitIsZero(SignBit.getReg(0)));
 }

Modified: llvm/trunk/unittests/CodeGen/GlobalISel/MachineIRBuilderTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/CodeGen/GlobalISel/MachineIRBuilderTest.cpp?rev=374595&r1=374594&r2=374595&view=diff
==============================================================================
--- llvm/trunk/unittests/CodeGen/GlobalISel/MachineIRBuilderTest.cpp (original)
+++ llvm/trunk/unittests/CodeGen/GlobalISel/MachineIRBuilderTest.cpp Fri Oct 11 13:58:26 2019
@@ -74,6 +74,7 @@ TEST_F(GISelMITest, TestBuildConstantFCo
 #endif
 
 TEST_F(GISelMITest, DstOpSrcOp) {
+  setUp();
   if (!TM)
     return;
 
@@ -99,6 +100,7 @@ TEST_F(GISelMITest, DstOpSrcOp) {
 }
 
 TEST_F(GISelMITest, BuildUnmerge) {
+  setUp();
   if (!TM)
     return;
 
@@ -119,6 +121,7 @@ TEST_F(GISelMITest, BuildUnmerge) {
 }
 
 TEST_F(GISelMITest, TestBuildFPInsts) {
+  setUp();
   if (!TM)
     return;
 
@@ -154,6 +157,7 @@ TEST_F(GISelMITest, TestBuildFPInsts) {
 }
 
 TEST_F(GISelMITest, BuildIntrinsic) {
+  setUp();
   if (!TM)
     return;
 
@@ -182,6 +186,7 @@ TEST_F(GISelMITest, BuildIntrinsic) {
 }
 
 TEST_F(GISelMITest, BuildXor) {
+  setUp();
   if (!TM)
     return;
 
@@ -210,6 +215,7 @@ TEST_F(GISelMITest, BuildXor) {
 }
 
 TEST_F(GISelMITest, BuildBitCounts) {
+  setUp();
   if (!TM)
     return;
 
@@ -237,6 +243,7 @@ TEST_F(GISelMITest, BuildBitCounts) {
 }
 
 TEST_F(GISelMITest, BuildCasts) {
+  setUp();
   if (!TM)
     return;
 
@@ -261,6 +268,7 @@ TEST_F(GISelMITest, BuildCasts) {
 }
 
 TEST_F(GISelMITest, BuildMinMax) {
+  setUp();
   if (!TM)
     return;
 
@@ -286,6 +294,7 @@ TEST_F(GISelMITest, BuildMinMax) {
 }
 
 TEST_F(GISelMITest, BuildAtomicRMW) {
+  setUp();
   if (!TM)
     return;