[PATCH] D68764: [ARM][AsmParser] handles offset expression in parentheses

Jian Cai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 11 13:45:33 PDT 2019


jcai19 marked 3 inline comments as done.
jcai19 added inline comments.


================
Comment at: llvm/test/MC/ARM/gas-compl-mem-offset-paren.s:3
+
+.syntax unified
+
----------------
nickdesaulniers wrote:
> If you remove this assembler directive outright, does the test still pass? If so, let's remove it.  Also, it seems that you partially removed the other occurrences, but not all of them.  It should occur once, or not at all (unless you wanted to test changing back and forth between them, but that's not what we're testing here).
Oops! Thanks for the catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68764/new/

https://reviews.llvm.org/D68764





More information about the llvm-commits mailing list