[PATCH] D68836: [lit] Small cleanups in main.py

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 11 13:37:07 PDT 2019


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: llvm/utils/lit/lit/main.py:32
+        import tempfile
         lit_tmp = tempfile.mkdtemp(prefix="lit_tmp_")
         os.environ.update({
----------------
Unrelated, but I wonder if we should augment this logic to garbage collect old `lit_tmp_` directories that are 24+ hours old. I routinely find lots of leaked lit_tmp_ directories because oftentimes the parent Python process is killed before it gets to the finally block below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68836/new/

https://reviews.llvm.org/D68836





More information about the llvm-commits mailing list