[PATCH] D68819: [Utils] Allow update_test_checks to check function arguments

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 11 10:51:55 PDT 2019


jdoerfert added a comment.

In D68819#1705424 <https://reviews.llvm.org/D68819#1705424>, @greened wrote:

> In D68819#1704962 <https://reviews.llvm.org/D68819#1704962>, @jdoerfert wrote:
>
> > We can, or should, combine D68153 <https://reviews.llvm.org/D68153> and this, either in one or two patches.
>
>
> Sounds good.  Do you think D68153 <https://reviews.llvm.org/D68153> should operate under the `--function-signature` flag, under a different flag or always include `define` in the pattern (meaning all tests will change when the tool is re-run)?


I think D68153 <https://reviews.llvm.org/D68153> is a small enough change and at the same time helpful enough to run it always. Adding function signature is not for everyone so I added the flag. I can put it under the flag if people think it should live there though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68819/new/

https://reviews.llvm.org/D68819





More information about the llvm-commits mailing list