[PATCH] D68848: [llvm-objdump] Use a counter for llvm-objdump -h instead of the section index.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht updated this revision to Diff 224632.
rupprecht marked 9 inline comments as done.
rupprecht added a comment.

- Add/update several comments
- Use simplified pointer check
- Avoid auto as the returned type is not obvious


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68848/new/

https://reviews.llvm.org/D68848

Files:
  lld/test/ELF/got32-i386.s
  lld/test/ELF/got32x-i386.s
  llvm/test/tools/llvm-objdump/section-headers.test
  llvm/test/tools/llvm-objdump/wasm.txt
  llvm/test/tools/llvm-objdump/xcoff-section-headers.test
  llvm/tools/llvm-objdump/llvm-objdump.cpp
  llvm/tools/llvm-objdump/llvm-objdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68848.224632.patch
Type: text/x-patch
Size: 17037 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191011/1eeca91f/attachment.bin>