[PATCH] D68033: [llvm-ar] Make paths case insensitive when on windows

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo marked an inline comment as done.
gbreynoo added inline comments.


================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:509
+#else
+  return normalizePath(Path1) == normalizePath(Path2);
+#endif
----------------
rupprecht wrote:
> I'm not quite sure about this change... a few of the callsites before were `Name == normalizePath(Path)`, not `normalizePath(Name) == normalizePath(Path)`. My past experiences of compatibility testing llvm-ar vs GNU ar has largely been paged out, but I think this may have been one of the differences. It may actually be something we want, but we should test it. e.g. to test the `performReadOperation` can you see if extracting "foo/file.txt" will end up extracting "bar/file.txt" (in a situation where `CompareFullPath` is false)?
You are correct. I have added a test for this behaviour which now matches that of gnu-ar.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68033/new/

https://reviews.llvm.org/D68033