[PATCH] D68656: Add ExceptionStream to llvm::Object::minidump

[Joseph Tremoulet via Phabricator via llvm-commits]

JosephTremoulet marked 3 inline comments as done.
JosephTremoulet added inline comments.


================
Comment at: llvm/unittests/Object/MinidumpTest.cpp:756-758
+  if (!ExpectedStream) {
+    errs() << ExpectedStream.takeError();
+  }
----------------
labath wrote:
> Delete. The ASSERT_THAT_EXPECTED check should already print the error message if this fails. Was that not working for you for some reason?
Yeah, that does work as expected, this was leftover cruft from when I was misunderstanding the error message while writing the test, good catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68656/new/

https://reviews.llvm.org/D68656