[PATCH] D60902: [OCaml] Add OCaml APIs to access DebugInfo

whitequark via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 11 06:59:10 PDT 2019


whitequark added a comment.

> @whitequark, with this diff's approach of creating a hierarchy of types to mirror the LLVM-C DI types, is it acceptable to add the types and functions incrementally? That is, could we land this diff and add other types and functions later?

Yes, that would be perfectly fine, and is in line with the extension of LLVM-C in the past.

> Another question is about opam. Since this diff adds a sub-library, the opam package files will need to change. Is there any experience / best practice about how to handle this? In particular, since the opam package files are not in the llvm repo, it will not be easily possible to pin the llvm dev repo.

I'm afraid there's no existing procedure for this. If the opam file does not have to be in the root of the repo (I forget exactly how it works), we could add it here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60902/new/

https://reviews.llvm.org/D60902





More information about the llvm-commits mailing list