[PATCH] D68778: [mips] Store 64-bit `li.d' operand as a single 8-byte value
Miloš Stojanović via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 11 06:22:11 PDT 2019
mstojanovic accepted this revision.
mstojanovic added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp:3436
getStreamer().EmitLabel(Sym, IDLoc);
- getStreamer().EmitIntValue(HiImmOp64, 4);
- getStreamer().EmitIntValue(LoImmOp64, 4);
+ getStreamer().EmitValueToAlignment(8);
+ getStreamer().EmitIntValue(ImmOp64, 8);
----------------
With the elimination of `HiImmOp64` and `LoImmOp64` here the use of most of these variables goes down to a single place in the code which creates a chance for inlining, though they look fine even without that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68778/new/
https://reviews.llvm.org/D68778
More information about the llvm-commits
mailing list