[PATCH] D67950: [TableGen] Fix a bug that MCSchedClassDesc is interfered between different SchedModel
Qing Shan Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 11 04:13:49 PDT 2019
steven.zhang added a comment.
In D67950#1705613 <https://reviews.llvm.org/D67950#1705613>, @andreadb wrote:
> I am not convinced that this patch is correct. Isn’t the problem that your model was wrongly marked as complete?
Even we marked the model complete wrongly, the table-gen should generate the data or diagnose correctly. And yes, the table-gen will emit diagnose messages, but still emit the SCDesc as valid, which messy the model.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67950/new/
https://reviews.llvm.org/D67950
More information about the llvm-commits
mailing list