[PATCH] D68656: Add ExceptionStream to llvm::Object::minidump

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

Looks fine, just a few nits inline.



================
Comment at: llvm/include/llvm/BinaryFormat/Minidump.h:228
 
+// Exception stuff
+struct Exception {
----------------
Delete or put a more meanigful comment here.


================
Comment at: llvm/unittests/Object/MinidumpTest.cpp:756-758
+  if (!ExpectedStream) {
+    errs() << ExpectedStream.takeError();
+  }
----------------
Delete. The ASSERT_THAT_EXPECTED check should already print the error message if this fails. Was that not working for you for some reason?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68656/new/

https://reviews.llvm.org/D68656