[PATCH] D68633: fix debug info affects output when opt inline

Chris Ye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 20:02:45 PDT 2019


yechunliang updated this revision to Diff 224534.
yechunliang marked an inline comment as done.
yechunliang added a comment.

Update patch:

1. Use BasicBlock::iterator skipDebugIntrinsics instead of rolling directly.  The recommend API BasicBlock:: instructionsWithoutDebug() looks not very suitable to handle llvm::Instruction in this code.
2. follow llvm style, condition: break first, then unconditionally execute the code


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68633/new/

https://reviews.llvm.org/D68633

Files:
  llvm/lib/Transforms/Utils/InlineFunction.cpp
  llvm/test/Transforms/Inline/inline-with-debuginfo.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68633.224534.patch
Type: text/x-patch
Size: 6738 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191011/022f8daf/attachment.bin>


More information about the llvm-commits mailing list