[PATCH] D68766: [NFC][ArgPromo][Tests] Run update_test_checks on all ArgumentPromotion tests

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 19:49:37 PDT 2019


jdoerfert added a comment.

In D68766#1704577 <https://reviews.llvm.org/D68766#1704577>, @lebedev.ri wrote:

> If you want to add attributor runlines, i really insist on following the example i showed, it will result in cleaner diff overall.
>  That being said i like that the attributor runlines are in a separate diff.


D68852 <https://reviews.llvm.org/D68852> adds the "privatizable pointer" attribute to the Attributor and runs it on all these test. I can split it so we first run it without the privatizable pointer attribute but it's unclear if that is helpful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68766/new/

https://reviews.llvm.org/D68766





More information about the llvm-commits mailing list