[PATCH] D68774: [libFuzzer] Don't prefix absolute paths in fuchsia.

Marco Vanotti via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 19:31:23 PDT 2019


charco marked 2 inline comments as done.
charco added inline comments.


================
Comment at: compiler-rt/lib/fuzzer/FuzzerUtilFuchsia.cpp:415
+    bool IsAbsolutePath = Path.length() > 1 && Path[0] == '/';
+    if (!IsAbsolutePath && Cmd.hasFlag("artifact_prefix")) {
+      Path = Cmd.getFlagValue("artifact_prefix") + "/" + Path;
----------------
phosek wrote:
> Nit: no curly braces for block with a single statement (LLVM style).
Thanks! I didn't know about this rule. Could you point me to where it is defined? I checked http://llvm.org/docs/CodingStandards.html#source-code-formatting and also tried to see if clang-format -style=LLVM catched it but nothing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68774/new/

https://reviews.llvm.org/D68774





More information about the llvm-commits mailing list