[PATCH] D68848: [llvm-objdump] Use a counter for llvm-objdump -h instead of the section index.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 18:17:31 PDT 2019


rupprecht created this revision.
rupprecht added reviewers: grimar, jhenderson.
rupprecht added a project: LLVM.
Herald added subscribers: llvm-commits, seiya, arphaman, aheejin, arichardson, sbc100, emaste.
Herald added a reviewer: espindola.
rupprecht added a parent revision: D68730: [llvm-objdump] Adjust spacing and field width for --section-headers.
rupprecht updated this revision to Diff 224519.
rupprecht added a comment.

Rebase against D68730 <https://reviews.llvm.org/D68730>


When listing the index in `llvm-objdump -h`, use a zero-based counter instead of the actual section index (e.g. shdr->sh_index for ELF).

While this is effectively a noop for now (except one unit test for XCOFF), the index values will change in a future patch that filters certain sections out (e.g. symbol tables). See D68669 <https://reviews.llvm.org/D68669> for more context.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68848

Files:
  llvm/test/tools/llvm-objdump/xcoff-section-headers.test
  llvm/tools/llvm-objdump/llvm-objdump.cpp
  llvm/tools/llvm-objdump/llvm-objdump.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68848.224519.patch
Type: text/x-patch
Size: 6120 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191011/533afcaf/attachment.bin>


More information about the llvm-commits mailing list