[PATCH] D68153: Make IR labels more precise

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 17:04:12 PDT 2019


jdoerfert added a comment.

In D68153#1698833 <https://reviews.llvm.org/D68153#1698833>, @greened wrote:

> In D68153#1689791 <https://reviews.llvm.org/D68153#1689791>, @RKSimon wrote:
>
> > Wouldn't this mean that every regeneration would see this change?
>
>
> Yes.  The label pattern is just wrong as-is because it will match calls in some cases.


I experienced this case myself now. I really like this change and I think breaking things now is better than debugging it over and over again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68153/new/

https://reviews.llvm.org/D68153





More information about the llvm-commits mailing list