[llvm] r374475 - [JITLink] Move MachO/x86 got test further down in the data section.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 16:37:49 PDT 2019


Author: lhames
Date: Thu Oct 10 16:37:49 2019
New Revision: 374475

URL: http://llvm.org/viewvc/llvm-project?rev=374475&view=rev
Log:
[JITLink] Move MachO/x86 got test further down in the data section.

'named_data' should be the first symbol in the data section.

Modified:
    llvm/trunk/test/ExecutionEngine/JITLink/X86/MachO_x86-64_relocations.s

Modified: llvm/trunk/test/ExecutionEngine/JITLink/X86/MachO_x86-64_relocations.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/JITLink/X86/MachO_x86-64_relocations.s?rev=374475&r1=374474&r2=374475&view=diff
==============================================================================
--- llvm/trunk/test/ExecutionEngine/JITLink/X86/MachO_x86-64_relocations.s (original)
+++ llvm/trunk/test/ExecutionEngine/JITLink/X86/MachO_x86-64_relocations.s Thu Oct 10 16:37:49 2019
@@ -129,18 +129,6 @@ Lanon_minuend_quad:
 Lanon_minuend_long:
         .long Lanon_minuend_long - named_data + 2
 
-# Check X86_64_RELOC_GOT handling.
-# X86_64_RELOC_GOT is the data-section counterpart to X86_64_RELOC_GOTLD. It is
-# handled exactly the same way, including having an implicit PC-rel offset of -4
-# (despite this not making sense in a data section, and requiring an explicit
-# +4 addend to cancel it out and get the correct result).
-#
-# jitlink-check: *{4}test_got = (got_addr(macho_reloc.o, external_data) - test_got)[31:0]
-        .globl test_got
-        .p2align  2
-test_got:
-        .long   external_data at GOTPCREL + 4
-
 # Named quad storage target (first named atom in __data).
         .globl named_data
         .p2align  3
@@ -284,6 +272,18 @@ subtractor_with_alt_entry_subtrahend_qua
 subtractor_with_alt_entry_subtrahend_quad_B:
         .quad 0
 
+# Check X86_64_RELOC_GOT handling.
+# X86_64_RELOC_GOT is the data-section counterpart to X86_64_RELOC_GOTLD. It is
+# handled exactly the same way, including having an implicit PC-rel offset of -4
+# (despite this not making sense in a data section, and requiring an explicit
+# +4 addend to cancel it out and get the correct result).
+#
+# jitlink-check: *{4}test_got = (got_addr(macho_reloc.o, external_data) - test_got)[31:0]
+        .globl test_got
+        .p2align  2
+test_got:
+        .long   external_data at GOTPCREL + 4
+
 # Check that unreferenced atoms in no-dead-strip sections are not dead stripped.
 # We need to use a local symbol for this as any named symbol will end up in the
 # ORC responsibility set, which is automatically marked live and would couse




More information about the llvm-commits mailing list