[PATCH] D68194: [LCSSA] Forget values we create LCSSA phis for

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopUnroll/unroll-preserve-scev-lcssa.ll:76
+bb3:                                              ; preds = %bb9, %bb
+  br i1 undef, label %bb9, label %bb5
+
----------------
sanjoy.google wrote:
> Minor thing: I'd avoid adding branches on `undef` (unless you need them to reproduce the test) because there is no  guarantee on how the optimizers will optimize these.
> 
> (It is also unclear whether this is UB.)
Excellent point, thanks! This was originally reduced by bug point which likes undef, but I've added proper conditions now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68194/new/

https://reviews.llvm.org/D68194