[PATCH] D68819: [Utils] Allow update_test_checks to check function arguments

David Greene via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 13:25:54 PDT 2019


greened added a comment.

Does this subsume the goal of D68153 <https://reviews.llvm.org/D68153>?  If so I am happy to abandon that revision.  D68153 <https://reviews.llvm.org/D68153> attempts to solve the problem of a `CHECK-LABEL` matching a function call instead of the start of a function definition.  It looks like with `--function-signature` the `CHECK-LABEL` will include the arguments in the label pattern which should be enough to disambiguate it from a call to the function.  Do I have that right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68819/new/

https://reviews.llvm.org/D68819





More information about the llvm-commits mailing list