[PATCH] D68586: Save a word in every StringSet entry

[Jordan Rose via Phabricator via llvm-commits]

jordan_rose added a comment.

In D68586#1704530 <https://reviews.llvm.org/D68586#1704530>, @dblaikie wrote:

> Any idea why MDString is friending an implementation detail like this? Should it be? Could we make it an actual private implementation detail so people can't do this?


It's funky but I think reasonable: MDString is a move-none type since there will be direct pointers to it, and the canonical instance lives in the StringMap. Disallowing this friending would mean making MDString move-only and just assuming it'll never be misused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68586/new/

https://reviews.llvm.org/D68586