[llvm] r374441 - [lit] Add comment explaining the LIT_OPTS env var overrides command line options

[Julian Lettner via llvm-commits]

Author: yln
Date: Thu Oct 10 13:23:28 2019
New Revision: 374441

URL: http://llvm.org/viewvc/llvm-project?rev=374441&view=rev
Log:
[lit] Add comment explaining the LIT_OPTS env var overrides command line options

Normally, command line options override environment variables.  Add
comment to state that we are doing the reverse on purpose.

Modified:
    llvm/trunk/utils/lit/lit/cl_arguments.py

Modified: llvm/trunk/utils/lit/lit/cl_arguments.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/cl_arguments.py?rev=374441&r1=374440&r2=374441&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/cl_arguments.py (original)
+++ llvm/trunk/utils/lit/lit/cl_arguments.py Thu Oct 10 13:23:28 2019
@@ -183,8 +183,10 @@ def parse_args():
             action="store_true",
             default=False)
 
-    opts = parser.parse_args(sys.argv[1:] +
-                             shlex.split(os.environ.get("LIT_OPTS", "")))
+    # LIT is special: environment variables override command line arguments.
+    env_args = shlex.split(os.environ.get("LIT_OPTS", ""))
+    args = sys.argv[1:] + env_args
+    opts = parser.parse_args(args)
 
     # Validate command line options
     if opts.echoAllCommands: