[PATCH] D61675: [WIP] Update IRBuilder::CreateFNeg(...) to return a UnaryOperator

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 12:00:01 PDT 2019


cameron.mcinally added a subscriber: RKSimon.
cameron.mcinally added a comment.

@gribozavr I see that you also reverted @RKSimon's commit for the OCaml/core.ml failure:

  Author: gribozavr
  Date: Thu Oct 10 07:16:58 2019
  New Revision: 374357
  
  URL: http://llvm.org/viewvc/llvm-project?rev=374357&view=rev
  Log:
  Revert "Fix OCaml/core.ml fneg check"
  
  This reverts commit r374346. It attempted to fix OCaml tests, but is
  does not actually fix them.
  
  Modified:
      llvm/trunk/test/Bindings/OCaml/core.ml

That appears to be the proper fix. Do you see something wrong with it that I'm missing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61675/new/

https://reviews.llvm.org/D61675





More information about the llvm-commits mailing list