[PATCH] D68744: [GSYM] Add GsymCreator and GsymReader.

[Greg Clayton via Phabricator via llvm-commits]

clayborg added a comment.

In D68744#1704377 <https://reviews.llvm.org/D68744#1704377>, @thakis wrote:

> The fix attempt didn't work:
>
>   ECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -DUNICODE -I../../llvm/include -Igen/llvm/include /O2 /Zc:inline /EHs-c- /W4 -Wno-unused-parameter -Wdelete-non-virtual-dtor -Wstring-conversion -Wno-nonportable-include-path -Wcovered-switch-default /GR-
>   ../../llvm/lib/DebugInfo/GSYM/GsymCreator.cpp(76,3): error: use of undeclared identifier 'bzero'
>     bzero(Hdr.UUID, sizeof(Hdr.UUID));
>     ^
>   1 error generated.
>   [16/106] CXX obj/llvm/lib/DebugInfo/GSYM/GSYM.GsymReader.obj
>   FAILED: obj/llvm/lib/DebugInfo/GSYM/GSYM.GsymReader.obj 
>   c:\src\goma\goma-win64/gomacc c:/src/chrome/src/third_party/llvm-build/Release+Asserts/bin/clang-cl /nologo /showIncludes /Foobj/llvm/lib/DebugInfo/GSYM/GSYM.GsymReader.obj /c ../../llvm/lib/DebugInfo/GSYM/GsymReader.cpp -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_UNICODE -DUNICODE -I../../llvm/include -Igen/llvm/include /O2 /Zc:inline /EHs-c- /W4 -Wno-unused-parameter -Wdelete-non-virtual-dtor -Wstring-conversion -Wno-nonportable-include-path -Wcovered-switch-default /GR-
>   ../../llvm/lib/DebugInfo/GSYM/GsymReader.cpp(19,10): fatal error: 'unistd.h' file not found
>   #include <unistd.h>
>


$ svn commit
Sending        lib/DebugInfo/GSYM/GsymCreator.cpp
Transmitting file data .done
Committing transaction...
Committed revision 374409.
$ svn commit
Sending        lib/DebugInfo/GSYM/GsymReader.cpp
Transmitting file data .done
Committing transaction...
Committed revision 374410.

Switched to memset and removed include of unistd.h


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68744/new/

https://reviews.llvm.org/D68744