[PATCH] D68766: [NFC][ArgPromo][Tests] Run update_test_checks on all ArgumentPromotion tests

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert marked 2 inline comments as done.
jdoerfert added a comment.

Thx for the initial feedback, I'll update this soon.



================
Comment at: llvm/test/Transforms/ArgumentPromotion/2008-02-01-ReturnAttrs.ll:2-3
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
 ; RUN: opt < %s -argpromotion -S | FileCheck %s
+; RUN: opt < %s -aa-pipeline='basic-aa' -passes=attributor -attributor-disable=false -attributor-max-iterations-verify -attributor-max-iterations=1 -S | FileCheck %s --check-prefix=ATTRIBUTOR
 
----------------
lebedev.ri wrote:
> Do you want:
> ```
> ; RUN: opt < %s -argpromotion -S | FileCheck %s --check-prefixes=ALL,ARGPROMOTION
> ; RUN: opt < %s -aa-pipeline='basic-aa' -passes=attributor -attributor-disable=false -attributor-max-iterations-verify -attributor-max-iterations=1 -S | FileCheck %s --check-prefixes=ALL,ATTRIBUTOR
> ```
> ?
Will do


================
Comment at: llvm/test/Transforms/ArgumentPromotion/musttail.ll:45
 define internal i32 @test2(%T* %p, i32 %p2) {
+; CHECK-LABEL: define internal i32 @test2(%T* %p, i32 %p2)
+; CHECK-NEXT:    [[A_GEP:%.*]] = getelementptr [[T:%.*]], %T* [[P:%.*]], i64 0, i32 3
----------------
lebedev.ri wrote:
> does the script produce these verbose check-lines for define?
> I think i usually saw it producing just the name.
I took the original check lines where it made sense but I can also drop these in favor of the auto-generated ones, or I can allow the script to emit the arguments (which I think I preferred). I'll update the tests once I've done that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68766/new/

https://reviews.llvm.org/D68766