[PATCH] D68465: [DebugInfo] Trim call-clobbered location list entries when tuning for GDB

[David Stenberg via Phabricator via llvm-commits]

dstenb added a comment.

In D68465#1697824 <https://reviews.llvm.org/D68465#1697824>, @probinson wrote:

> Debugger tuning should not be used directly this way.  There should be a DwarfDebug flag, and a CL option, and the default set in the DwarfDebug ctor based on tuning.  This allows the defaulting to work how you want, but can be overridden easily for experimentation and testing.  There are lots of examples of doing this in the ctor already.  Also, if it turns out some other debugger also needs this, it's trivial to fix up the ctor to handle it with no code changes needed elsewhere.


Oh, right. That makes sense. When I added that I saw that there were inline uses of the tuner queries in `constructCallSiteEntryDIEs()` already, so I did not consider that. Perhaps those uses should be addressed also.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68465/new/

https://reviews.llvm.org/D68465