[PATCH] D67322: [LLD][ThinLTO] Handle GUID collision in import global processing

Thu Oct 10 09:18:09 PDT 2019

tejohnson added a comment.

In D67322#1704084 <https://reviews.llvm.org/D67322#1704084>, @evgeny777 wrote:

> I wonder how such thing happened in the first place. Can linker produce working image even if we circumvent the crash?

There isn't an ODR issue since they are both locals. The GUID is the same because, since it is a local, the name is created by prepending the source_filename, which is "-" in both cases, which defeats our normal mechanism for creating a unique GUID for locals. It turned out this was due to the way clang was being invoked by icecc (see the bug for details). It was also addressed separately by D67592 <https://reviews.llvm.org/D67592>, but this is still good to fix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67322/new/

https://reviews.llvm.org/D67322