[PATCH] D68396: [LLD][ELF] Fix stale comment about doing ICF

[Russell Gallop via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG6d6ec1b869cf: [LLD][ELF] Fix stale comments about doing ICF (authored by russell.gallop).

Changed prior to commit:
  https://reviews.llvm.org/D68396?vs=224333&id=224342#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68396/new/

https://reviews.llvm.org/D68396

Files:
  lld/ELF/Driver.cpp


Index: lld/ELF/Driver.cpp
===================================================================
--- lld/ELF/Driver.cpp
+++ lld/ELF/Driver.cpp
@@ -1915,9 +1915,10 @@
   // Replace common symbols with regular symbols.
   replaceCommonSymbols();
 
-  // Do size optimizations: garbage collection, merging of SHF_MERGE sections
-  // and identical code folding.
+  // Split SHF_MERGE and .eh_frame sections into pieces in preparation for garbage collection.
   splitSections<ELFT>();
+
+  // Garbage collection and removal of shared symbols from unused shared objects.
   markLive<ELFT>();
   demoteSharedSymbols();
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68396.224342.patch
Type: text/x-patch
Size: 612 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191010/af8dfda9/attachment.bin>