[PATCH] D68396: [LLD][ELF] Fix stale comment about doing ICF
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 10 06:57:30 PDT 2019
MaskRay added inline comments.
================
Comment at: lld/ELF/Driver.cpp:1918
+ // Do size optimizations: splitting of sections and garbage collection.
splitSections<ELFT>();
markLive<ELFT>();
----------------
peter.smith wrote:
> MaskRay wrote:
> > @peter.smith in case he has suggestions for the wording.
> I've got a minor suggestion, no strong opinions though.
>
> I think it might be worth commenting separately about splitSections as it isn't obvious why it is where it is. Something like:
> ```
> // Split SHF_MERGE and .eh_frame sections into pieces in preparation for garbage collection.
> splitSections<ELFT>();
> // Garbage collection and removal of unused shared objects from dependencies.
> markLive<ELFT>();
> demoteSharedSymbols();
> ```
>
not removal of unused shared objects
it is to change the symbol kind
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68396/new/
https://reviews.llvm.org/D68396
More information about the llvm-commits
mailing list