[PATCH] D68472: [test] Use system locale for mri-utf8.test
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 10 06:38:24 PDT 2019
thopre added a comment.
In D68472#1703619 <https://reviews.llvm.org/D68472#1703619>, @thakis wrote:
> This fails on macOS: http://45.33.8.238/mac/1350/step_10.txt
>
> Relying on the system default locale seems a lot more brittle than relying on utf8. Requiring utf8 to be able to run llvm's tests seems like an ok requirement to me.
>
> But in any case, please take a look at the breakage on Mac, and if it takes a while to fix please revert while you investigate.
As mentioned in the commit message, Windows requires UTF-16 so would need to be treated specially. Besides, even on Linux the problem is that it relies on a specific locale rather than UTF-8. Anyway, I've reverted the commit for now. @gbreynoo the test appears to be passing on Mac OS with this commit. Is llvm-ar really expected to fail dealing with nonascii characters on Mac OS X?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68472/new/
https://reviews.llvm.org/D68472
More information about the llvm-commits
mailing list