[PATCH] D68396: [LLD][ELF] Fix stale comment about doing ICF

[Peter Smith via Phabricator via llvm-commits]

peter.smith added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1918
+  // Do size optimizations: splitting of sections and garbage collection.
   splitSections<ELFT>();
   markLive<ELFT>();
----------------
MaskRay wrote:
> @peter.smith in case he has suggestions for the wording.
I've got a minor suggestion, no strong opinions though. 

I think it might be worth commenting separately about splitSections as it isn't obvious why it is where it is. Something like:
```
  // Split SHF_MERGE and .eh_frame sections into pieces in preparation for garbage collection.
  splitSections<ELFT>();
  // Garbage collection and removal of unused shared objects from dependencies.
  markLive<ELFT>();
  demoteSharedSymbols();
```



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68396/new/

https://reviews.llvm.org/D68396