[PATCH] D66613: [support][llvm-objcopy] Add support for shell wildcards

Eugene Leviant via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 04:44:18 PDT 2019


evgeny777 added a comment.

I wonder if you can use GlobPattern (llvm/Support/GlobPattern.h) or extend this class. One of the reasons we use it in lld is because of much better performance (see D26241 <https://reviews.llvm.org/D26241>),
This may not be the case for llvm-objcopy, but still using original pattern matcher looks nicer than translating to regexps.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66613/new/

https://reviews.llvm.org/D66613





More information about the llvm-commits mailing list