[PATCH] D68771: [llvm-readelf] - Do not enter an infinite loop when printing histogram.

[George Rimar via Phabricator via llvm-commits]

grimar planned changes to this revision.
grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: test/tools/llvm-readobj/elf-hash-histogram.test:51
+    Flags: [SHF_ALLOC]
+    Address: 0x1000
+    AddressAlign: 0x1000
----------------
grimar wrote:
> MaskRay wrote:
> > Delete all of `Address AddressAlign VAddr` (see elf-hash-symbols.test)
> I think I can't, `elf-hash-symbols.test` is different, see:
> https://github.com/llvm-mirror/llvm/blob/master/tools/llvm-readobj/ELFDumper.cpp#L3954
> 
> Here `getHashTable` returns something based on DT_HASH:
> https://github.com/llvm-mirror/llvm/blob/master/tools/llvm-readobj/ELFDumper.cpp#L1713
> 
> I.e, I think I've already simplified this YAML to a minimum or at least to a very reasonable minimum.
> Am I missing something?
Ah, sorry, I've got it now. I've looked at the wrong test case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68771/new/

https://reviews.llvm.org/D68771