[PATCH] D67728: Scrub FileCheck regex delimiters from test checks

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 03:28:44 PDT 2019


MaskRay added a comment.

In D67728#1675450 <https://reviews.llvm.org/D67728#1675450>, @greened wrote:

> In D67728#1674499 <https://reviews.llvm.org/D67728#1674499>, @RKSimon wrote:
>
> > Is there a suitable test case change?
>
>
> Are there tests for this tool?  I ran into this issue with some downstream testing.  I could mock-up a testcase but where does it go?


You can attach a minimalist example with generated CHECK lines before/after this change in the summary. Logic in this script is very tricky and such examples in the git logs will be very helpful to a future poor soul hacking the source.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67728/new/

https://reviews.llvm.org/D67728





More information about the llvm-commits mailing list