[PATCH] D68689: [LLD] [MinGW] Look for other library patterns with -l
Martin Storsjö via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 10 01:50:54 PDT 2019
Sure, feel free to.
// Martin
On Thu, 10 Oct 2019, Rui Ueyama wrote:
> OK, I can do that for you if it doesn't bother you.
>
> On Thu, Oct 10, 2019 at 4:20 PM Martin Storsjö via Phabricator
> <reviews at reviews.llvm.org> wrote:
> mstorsjo added a comment.
>
> In D68689#1703104 <https://reviews.llvm.org/D68689#1703104>,
> @ruiu wrote:
>
> > LGTM
> >
> > Using error instead of fatal is not a high priority matter for
> the MinGW driver because I believe users are using this driver
> as a command. But still it is better to use error because it is
> more like a contract as a library. So, can you make a follow-up
> change?
>
>
> I can try to make such a change a bit later, yes, but I've got a
> bit too many other things going on right now.
>
>
> CHANGES SINCE LAST ACTION
> https://reviews.llvm.org/D68689/new/
>
> https://reviews.llvm.org/D68689
>
>
>
>
>
More information about the llvm-commits
mailing list