[PATCH] D68758: Improve error message for bad SHF_MERGE sections

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 10 01:16:25 PDT 2019


MaskRay added inline comments.


================
Comment at: lld/test/ELF/invalid/merge-writable.s:1
+// REQUIRES: x86
+// RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
----------------
ruiu wrote:
> MaskRay wrote:
> > `git mv writable-merge.s merge-writable.s`
> This file is actually already `merge-writable.s`. Am I missing something?
There is an existing file writable-merge.s

I think we can reuse the test, though probably rename it to merge-writable.s


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68758/new/

https://reviews.llvm.org/D68758





More information about the llvm-commits mailing list