[PATCH] D68676: [ASan] Do not misrepresent high value address dereferences as null dereferences
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 9 19:45:28 PDT 2019
thakis added inline comments.
================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_win.cpp:949
+bool SignalContext::IsTrueFaultingAddress() const {
+ // TODO: Provide real implementation for this. See Linux and Mac variants.
+ return IsMemoryAccess();
----------------
This breaks a bunch of bots with `/home/buildbots/ppc64be-clang-lnt-test/clang-ppc64be-lnt/llvm/projects/compiler-rt/lib/sanitizer_common/sanitizer_win.cpp:949: Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68676/new/
https://reviews.llvm.org/D68676
More information about the llvm-commits
mailing list