[PATCH] D68689: [LLD] [MinGW] Look for other library patterns with -l

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM with this change.



================
Comment at: lld/MinGW/Driver.cpp:144-145
+      if (Optional<std::string> s = findFile(dir, "lib" + name + ".dll"))
+        fatal("lld doesn't support linking directly against " + *s +
+              ", use an import library");
+      if (Optional<std::string> s = findFile(dir, name + ".dll"))
----------------
It should be error instead of fatal, as our promise is that we use fatal only to report corrupted files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68689/new/

https://reviews.llvm.org/D68689