[compiler-rt] r374258 - [sanitizer_common] Remove OnPrint from Go build.
Matt Morehouse via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 9 15:57:07 PDT 2019
Author: morehouse
Date: Wed Oct 9 15:57:07 2019
New Revision: 374258
URL: http://llvm.org/viewvc/llvm-project?rev=374258&view=rev
Log:
[sanitizer_common] Remove OnPrint from Go build.
Summary: Go now uses __sanitizer_on_print instead.
Reviewers: vitalybuka, dvyukov
Reviewed By: vitalybuka
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68621
Modified:
compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cpp
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cpp
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cpp?rev=374258&r1=374257&r2=374258&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cpp (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_printf.cpp Wed Oct 9 15:57:07 2019
@@ -229,8 +229,6 @@ void SetPrintfAndReportCallback(void (*c
// Can be overriden in frontend.
#if SANITIZER_GO && defined(TSAN_EXTERNAL_HOOKS)
// Implementation must be defined in frontend.
-// TODO(morehouse): Remove OnPrint after migrating Go to __sanitizer_on_print.
-extern "C" void OnPrint(const char *str);
extern "C" void __sanitizer_on_print(const char *str);
#else
SANITIZER_INTERFACE_WEAK_DEF(void, __sanitizer_on_print, const char *str) {
@@ -239,10 +237,6 @@ SANITIZER_INTERFACE_WEAK_DEF(void, __san
#endif
static void CallPrintfAndReportCallback(const char *str) {
-#if SANITIZER_GO && defined(TSAN_EXTERNAL_HOOKS)
- // TODO(morehouse): Remove OnPrint after migrating Go to __sanitizer_on_print.
- OnPrint(str);
-#endif
__sanitizer_on_print(str);
if (PrintfAndReportCallback)
PrintfAndReportCallback(str);
More information about the llvm-commits
mailing list