[PATCH] D68684: [WebAssembly] Make returns variadic

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

I'll land this since it's just a WIP and not ready for users yet. I'm happy to discuss ABI limits and other considerations further and make changes in followups!



================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyFastISel.cpp:1309
 
+  // TODO: should probably be <= 2? But be conservative to start...
+  assert(Ret->getNumOperands() < 2 && "Multivalue return not supported yet");
----------------
aheejin wrote:
> Why <=2? If multivalues are supported in fastisel later, do we still have that limit?
Oops, this comment should have been removed. I'm updating this to just bail out of FastISel in the case of multiple return for now. The proper condition to check is `Ret->getNumOperands() > 1`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68684/new/

https://reviews.llvm.org/D68684