[PATCH] D51018: [sancov] Accommodate sancov and coverage report server for use under Windows

Wed Oct 9 14:22:15 PDT 2019

vitalybuka added a comment.

In D51018#1700811 <https://reviews.llvm.org/D51018#1700811>, @dgg5503 wrote:

> @vsk thanks for the review! It looks like the JSON support library implements what `JSONWriter` does in this tool. To reduce maintenance, I've updated sancov to use the JSON support library implementation instead. The only downside to this change is that the JSON text format differs compared to the original implementation. I'm open to reverting this diff and simply adding your suggested change which also worked. Let me know what you think.
>
> EDIT:
>  I've also updated the title and description to better describe the changes in this diff.

I like the change.

Could you move JSONWriter -> JSON refactoring into separate patch and rebase win stuff ontop?
If you don't have commiter access, someone will need to commit it for you
So I don't mind to split the patch and commit myself.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51018/new/

https://reviews.llvm.org/D51018