[PATCH] D68684: [WebAssembly] Make returns variadic

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 9 13:28:43 PDT 2019


dschuff added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp:1269
       if (MI.getOpcode() == WebAssembly::END_BLOCK) {
+        assert(MFI.getResults().size() <= 1 &&
+               "Multivalue block signatures not implemented yet");
----------------
sbc100 wrote:
> report_fatal_error so end users see this too?
By this time we should have legalized everything, so this can be an assert because it should never happen?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68684/new/

https://reviews.llvm.org/D68684





More information about the llvm-commits mailing list