[PATCH] D68724: [libFuzzer] Fix Alarm callback in fuchsia.

Jake Ehrlich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 9 13:19:35 PDT 2019


jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.

LGTM except a nit



================
Comment at: compiler-rt/lib/fuzzer/FuzzerLoop.cpp:276-277
   assert(Options.UnitTimeoutSec > 0);
   // In Windows Alarm callback is executed by a different thread.
   // NetBSD's current behavior needs this change too.
+#if !LIBFUZZER_WINDOWS && !LIBFUZZER_NETBSD && !LIBFUZZER_FUCHSIA
----------------
Can you mention that Fuchsia does the same thing as windows here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68724/new/

https://reviews.llvm.org/D68724





More information about the llvm-commits mailing list