[PATCH] D68601: [SampleFDO] Add indexing for function profiles so they can be loaded on demand in ExtBinary format
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 9 11:08:07 PDT 2019
davidxl added inline comments.
================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:533
+std::error_code SampleProfileReaderExtBinary::readFuncProfiles(uint64_t Size) {
+ const uint8_t *Start = Data;
+ if (UseAllFuncs) {
----------------
wmi wrote:
> davidxl wrote:
> > End = Data + Size
> It is set in the parent function: readOneSection.
What I meant is to define a local variable 'End' and use it instead of of Start. It makes code slightly more readable.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68601/new/
https://reviews.llvm.org/D68601
More information about the llvm-commits
mailing list