[PATCH] D68713: [FPEnv] Change test to conform to strictfp attribute rules

[Kevin P. Neal via Phabricator via llvm-commits]

kpn created this revision.
kpn added a reviewer: spatel.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This test does not conform to the new strictfp attribute rules. In particular, the function definition is not marked strictfp despite containing a function marked strictfp. Also, if any function call is marked strictfp then all function calls in that function must be marked.

This change to move the one strictfp call to a new properly marked function meets all the new rules.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D68713

Files:
  llvm/test/Bitcode/compatibility.ll


Index: llvm/test/Bitcode/compatibility.ll
===================================================================
--- llvm/test/Bitcode/compatibility.ll
+++ llvm/test/Bitcode/compatibility.ll
@@ -1374,9 +1374,6 @@
   call void @f.nobuiltin() builtin
   ; CHECK: call void @f.nobuiltin() #43
 
-  call void @f.strictfp() strictfp
-  ; CHECK: call void @f.strictfp() #44
-
   call fastcc noalias i32* @f.noalias() noinline
   ; CHECK: call fastcc noalias i32* @f.noalias() #12
   tail call ghccc nonnull i32* @f.nonnull() minsize
@@ -1392,6 +1389,13 @@
   ret void
 }
 
+define void @instructions.strictfp() #44 {
+  call void @f.strictfp() strictfp
+  ; CHECK: call void @f.strictfp() #44
+
+  ret void
+}
+
 define void @instructions.call_notail() {
   notail call void @f1()
   ; CHECK: notail call void @f1()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68713.224080.patch
Type: text/x-patch
Size: 807 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191009/fa27ceb5/attachment.bin>